Add SelectableParagraph component and SelectableTextViewManager#55635
Closed
NickGerleman wants to merge 2 commits intofacebook:mainfrom
Closed
Add SelectableParagraph component and SelectableTextViewManager#55635NickGerleman wants to merge 2 commits intofacebook:mainfrom
NickGerleman wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
NickGerleman
force-pushed
the
export-D93829400
branch
5 times, most recently
from
fced78a to
ff1a00c
Compare
NickGerleman
force-pushed
the
export-D93829400
branch
from
ff1a00c to
c0b06f6
Compare
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93829400. |
NickGerleman
force-pushed
the
export-D93829400
branch
from
c0b06f6 to
5824495
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 25, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
force-pushed
the
export-D93829400
branch
3 times, most recently
from
77af022 to
84b9f78
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 25, 2026
…book#55635) Summary: Pull Request resolved: facebook#55635 Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
force-pushed
the
export-D93829400
branch
from
84b9f78 to
4e82742
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
Summary: Extract ParagraphComponentDescriptor logic into a template base class BaseParagraphComponentDescriptor<ShadowNodeT> so that other paragraph-like component descriptors can reuse the same TextLayoutManager wiring. Remove `final` from ParagraphShadowNode to allow subclassing. Move TextLayoutManagerKey from extern linkage in .cpp to constexpr in the new header. This is a pure refactor with no behavioral change. Changelog: [Internal] Differential Revision: D93829402
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
force-pushed
the
export-D93829400
branch
from
4e82742 to
bdf5a40
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
force-pushed
the
export-D93829400
branch
from
bdf5a40 to
27f745b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 26, 2026
…book#55635) Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
…book#55635) Summary: Pull Request resolved: facebook#55635 Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400
NickGerleman
force-pushed
the
export-D93829400
branch
from
27f745b to
56f339e
Compare
|
This pull request has been merged in 1bf9356. |
zoontek
pushed a commit
to zoontek/react-native
that referenced
this pull request
Mar 9, 2026
…book#55635) Summary: Pull Request resolved: facebook#55635 Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D93829400 fbshipit-source-id: 3ab218c33082efef6000573db41738393337545f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on.
C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName.
Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText.
No JS code references RCTSelectableText yet, so the new components are inert.
Changelog:
[Internal]
Differential Revision: D93829400